Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement a tooling for slasher #6119

Merged
merged 1 commit into from
Aug 22, 2023
Merged

feat: Implement a tooling for slasher #6119

merged 1 commit into from
Aug 22, 2023
+285 −43

Conversation

simlecode
Copy link
Collaborator

关联的Issues (Related Issues)

lotus pr: 10928,11126

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前，需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题（接口, 配置，数据，灰度），如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

Codecov Report

Merging #6119 (a1cb32e) into feat/nv21 (eb6fe63) will decrease coverage by 1%.
The diff coverage is 1%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           feat/nv21   #6119    +/-   ##
==========================================
- Coverage         24%     24%    -1%     
==========================================
  Files            662     663     +1     
  Lines          80784   80925   +141     
==========================================
+ Hits           19771   19787    +16     
- Misses         58383   58511   +128     
+ Partials        2630    2627     -3

LinZexiao
LinZexiao approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao merged commit bcc72db into feat/nv21 Aug 22, 2023
@LinZexiao LinZexiao deleted the feat/slashfilter branch August 22, 2023 09:16
@simlecode simlecode added the nv21 合并 nv21 网络升级相关代码 label Aug 22, 2023
@simlecode simlecode self-assigned this Aug 22, 2023
@simlecode simlecode mentioned this pull request Aug 30, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinZexiao LinZexiao LinZexiao approved these changes

Assignees

@simlecode simlecode

Labels
nv21 合并 nv21 网络升级相关代码
Projects
Venus Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simlecode @codecov-commenter @LinZexiao